Review main Merged

72279[BUGFIX] Make selectCheckBox work with readOnly

Oli Bartsch CR +2 V +2 Hard +160 −165 updated 11/24/21, 23:07

Commit message

Using "readOnly" for a TCA field with renderType
"selectCheckBox" previously led to the fact, that
nothing was rendered at all. This can be seen with
`tx_styleguide_elements_select.select_checkbox_4`.

This is now fixed, while the whole element got a
light code cleanup. This will increase performance
a bit, since unneeded JavaScript is no longer loaded.

Additionally, this also fixes the "expandAll" option,
which was broken due to the bootstrap 5 upgrade.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 11/24/21, 18:06

  2. Oli Bartsch commented on patch set 1 11/24/21, 18:07

    I highly recommend to disable whitespace changes for this patch ;)
  3. core-ci voted on patch set 1 V +1 11/24/21, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19708

  4. Jochen Roth voted on patch set 1 V +1 CR +1 11/24/21, 18:58

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 11/24/21, 20:19

  6. Benni Mack voted on patch set 1 V +1 CR +1 11/24/21, 23:02

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 11/24/21, 23:07

  8. Oli Bartsch merged patch set 2 11/24/21, 23:07