Review main Merged

72281[TASK] Avoid a useless trait in FormEngine

Christian Kuhn CR +2 V +2 Normal +38 −56 updated 11/25/21, 13:17

Commit message

ext:backend Form/Element recently got a trait with #95954
that can be easily avoided by adding the method to
AbstractFormElement, which all elements should extend.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 67

  1. Christian Kuhn uploaded patch set 1 11/24/21, 23:21

  2. core-ci voted on patch set 1 V +1 11/24/21, 23:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19718

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 11/24/21, 23:40

  4. Oliver Hader voted on patch set 1 CR +1 11/25/21, 08:52

  5. Jochen Roth voted on patch set 1 V +1 CR +1 11/25/21, 12:43

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 11/25/21, 13:17

  7. Christian Kuhn merged patch set 2 11/25/21, 13:17