Review main Merged

72282[TASK] Avoid undefined key warning in rte editor

TYPO3com CR +2 V +2 Easy +28 −9 updated 11/27/21, 20:21

Commit message

Array access with undefined key emits undefined index warning.
This patch sanitize the calls to mitigate these warnings.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 813

  1. TYPO3com uploaded patch set 1 11/25/21, 10:45

  2. core-ci voted on patch set 1 V -1 11/25/21, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19726

  3. Stefan Bürk uploaded patch set 2 11/25/21, 19:27

  4. core-ci voted on patch set 2 V +1 11/25/21, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19757

  5. Benni Mack updated the commit message in patch set 3 11/25/21, 20:51

  6. core-ci voted on patch set 3 V +1 11/25/21, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19764

  7. Stefan Bürk commented on patch set 3 CR -1 11/27/21, 14:59

    There are some more. On it to add them too. And also re-evaluating original changes.
  8. Stefan Bürk uploaded patch set 4 11/27/21, 15:25

  9. core-ci voted on patch set 4 V +1 11/27/21, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19870

  10. Stefan Bürk voted on patch set 4 V +1 11/27/21, 17:46

  11. Stefan Bürk voted on patch set 4 CR +1 11/27/21, 20:21

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 11/27/21, 20:21

  13. Christian Kuhn merged patch set 5 11/27/21, 20:21