Review main Merged

72284[TASK] Avoid setting assertCleanReferenceIndex to false in tests

Christian Kuhn CR +2 V +2 Hard +184 −76 updated 11/25/21, 13:37

Commit message

Functional tests that extend AbstractDataHandlerActionTestCase
test for correct sys_refindex in tearDown(). This can
be avoided by setting assertCleanReferenceIndex to false,
which is only a temporary solution until reference updating
fully works.

The patch changes some import fixtures that come without
proper sys_refindex rows to avoid setting this property
to false.

One last call needs a dedicated bug fix and will have a
dedicated patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 810

  1. Christian Kuhn uploaded patch set 1 11/25/21, 11:20

  2. Christian Kuhn commented on patch set 1 11/25/21, 11:22

    WorkspaceNewPlaceholderRemovalTest.php:61

    It's ugly that assertCSVDataSet() does not work with an absolute path directly. I'll adapt that in TF soon.
  3. Christian Kuhn uploaded patch set 2 11/25/21, 11:23

  4. Christian Kuhn commented on patch set 2 11/25/21, 11:24

    note i'll soon add some helpers to testing-framework to simplify sys_refindex handling in functional tests.
  5. core-ci voted on patch set 1 V -1 11/25/21, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19729

  6. core-ci voted on patch set 2 V +1 11/25/21, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19730

  7. Jochen Roth voted on patch set 2 V +1 CR +1 11/25/21, 12:53

  8. Benni Mack voted on patch set 2 V +1 CR +1 11/25/21, 13:21

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 11/25/21, 13:37

  10. Christian Kuhn merged patch set 3 11/25/21, 13:37