Review main Merged

72286[BUGFIX] Improve legacy handling of not Composer installed extensions

Helmut Hummel CR +2 V +2 Easy +9 −14 updated 12/04/21, 10:24

Commit message

Starting with 11.4, in Composer managed TYPO3 installations,
having extensions, that are not installed by Composer, are deprecated.

They are still detected and registered though, by scanning the
typo3conf/ext folder and registering non Composer installed extensions
from there.

This process is now optimised to only read composer.json files
of extensions, that are known to not be installed via Composer,
instead of scanning all of them.

In that context it is now also ensured, that the root package,
in case it being an extension, is treated as "Composer installed".

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Simon Gilli +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Simon Gilli +1
    • Sybille Peters +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1720

  1. Helmut Hummel uploaded patch set 1 11/25/21, 13:07

  2. core-ci voted on patch set 1 V +1 11/25/21, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19735

  3. Simon Gilli commented on patch set 1 CR +1 11/25/21, 20:34

    PackageArtifactBuilder.php:301

    Not related to this change but why "root"?
  4. Simon Gilli voted on patch set 1 V +1 11/25/21, 22:07

  5. Benni Mack wrote 11/29/21, 10:20

    Change destination moved from master to main
  6. Benni Mack updated the commit message in patch set 2 11/29/21, 14:06

  7. Helmut Hummel commented on patch set 2 11/29/21, 15:07

    PackageArtifactBuilder.php:301 Reply

    Good question. The idea back then was: "extensions, that are part of the root package (and not installed via Composer)"
  8. Simon Gilli voted on patch set 2 V +1 CR +1 11/29/21, 16:16

  9. core-ci voted on patch set 2 V -1 11/29/21, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20086

  10. Stefan Bürk rebased onto patch set 3 12/01/21, 20:27

  11. core-ci voted on patch set 3 V +1 12/01/21, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20362

  12. Simon Gilli voted on patch set 3 V +1 CR +1 12/03/21, 13:06

  13. Stefan Bürk commented on patch set 3 12/03/21, 13:09

    Would be nice if Sybille could verify it is working for here now - if I'm right she was the origin for creating that issue and the fix.
  14. Helmut Hummel commented on patch set 3 12/03/21, 16:26

    Reply

    Yeah, makes sense!
  15. Sybille Peters commented on patch set 3 V +1 12/03/21, 19:44

    Looks like this solves original problem from me though I am having a little difficulty reproducing it. I have one extension where I can still reproduce it and problem goes away if PackageArtifactBuilder.php is replaced with version from this patch.
  16. Stefan Bürk voted on patch set 3 V +1 CR +1 12/03/21, 20:21

  17. Christian Kuhn voted on patch set 3 V +1 CR +1 12/03/21, 20:34

  18. Helmut Hummel voted on patch set 3 V +2 CR +2 12/04/21, 10:24

  19. Helmut Hummel commented on patch set 3 12/04/21, 10:24

    Thanks everybody for the reviews!
  20. Helmut Hummel merged patch set 4 12/04/21, 10:24