Review main Merged

72287[BUGFIX] Update CSV references when discarding record

Christian Kuhn CR +2 V +2 Normal +90 −15 updated 11/25/21, 21:34

Commit message

When an element is discarded in workspaces that is referenced
by another record in a group CSV field, those referencing
records need to be updated to no longer list the discarded
record.

The patch adds a method to DataHandler discard logic to
take care of that.

This resolves the very last call setting assertCleanReferenceIndex
to false. That test property has been a temporary solution and
is dropped now, tests extending AbstractDataHandlerActionTestCase
can no longer (easily) prevent the tearDown() refindex check and
should never do that again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1113

  1. Christian Kuhn uploaded patch set 1 11/25/21, 15:00

  2. core-ci voted on patch set 1 V -1 11/25/21, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19740

  3. Christian Kuhn uploaded patch set 2 11/25/21, 15:05

  4. Christian Kuhn updated the commit message in patch set 3 11/25/21, 15:07

  5. Christian Kuhn uploaded patch set 4 11/25/21, 15:14

  6. Christian Kuhn uploaded patch set 5 11/25/21, 15:17

  7. core-ci voted on patch set 5 V +1 11/25/21, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19744

  8. Stefan Bürk commented on patch set 5 11/25/21, 15:58

    DataHandler.php:5749

    Minor thing, but would suggest to enclose in '() here here - or not ? ``` ..., ($fieldTca['allowed'] ?? ''), ... ```

    AbstractDataHandlerActionTestCase.php:128

    nice ;)
  9. Christian Kuhn commented on patch set 5 11/25/21, 16:02

    DataHandler.php:5749 Reply

    not needed in method arguments - null coalescence binds stronger than argument separator.
  10. Stefan Bürk voted on patch set 5 V +1 CR +1 11/25/21, 16:02

  11. Benni Mack voted on patch set 5 V +1 CR +1 11/25/21, 19:11

  12. Christian Kuhn voted on patch set 5 V +2 CR +2 11/25/21, 21:33

  13. Christian Kuhn merged patch set 6 11/25/21, 21:34