72290[TASK] Improve page permission copyFromParent tests and docs
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 2
Review log 2027
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 11/25/21, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19749
-
core-ci voted on patch set 2 V +1 11/25/21, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19750
-
Christian Kuhn commented on patch set 2 11/26/21, 12:47
This change is ready for review.makes sense. please finish.PagePermissionTest.php:159Use actionService->modifyRecord() -
Stefan Bürk voted on patch set 2 CR -1 11/26/21, 12:48
-
Christian Kuhn voted on patch set 2 CR -1 11/26/21, 12:48
-
Christian Kuhn commented on patch set 2 11/26/21, 12:51
we should also improve the feature .rst a bit to show some scenarios why this can be useful. will update when stefan pushed his update. -
Stefan Bürk uploaded patch set 3 11/26/21, 13:11
-
Stefan Bürk commented on patch set 3 CR -1 11/26/21, 13:12
Christian will extend the .rst file.PagePermissionTest.php:159ReplyDone -
core-ci voted on patch set 3 V +1 11/26/21, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19790
-
Christian Kuhn uploaded patch set 4 11/26/21, 18:31
-
Christian Kuhn uploaded patch set 5 11/26/21, 18:32
-
Christian Kuhn updated the commit message in patch set 6 11/26/21, 18:33
-
Christian Kuhn voted on patch set 6 V +1 CR +1 11/26/21, 18:35
-
core-ci voted on patch set 4 V +1 11/26/21, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19820
-
core-ci voted on patch set 5 V +1 11/26/21, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19821
-
core-ci voted on patch set 6 V +1 11/26/21, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19822
-
Nikita Hovratov commented on patch set 6 11/26/21, 19:09
Feature-89917-InheritPageAccess.rst:57This closing bracket is wrong. -
Nikita Hovratov commented on patch set 6 11/26/21, 19:23
intended -
Stefan Bürk uploaded patch set 7 11/26/21, 19:59
-
Stefan Bürk commented on patch set 7 11/26/21, 20:00
Reply
DoneFeature-89917-InheritPageAccess.rst:57ReplyDone -
core-ci voted on patch set 7 V +1 11/26/21, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19830
-
Christian Kuhn voted on patch set 7 V +1 CR +1 11/26/21, 20:35
-
Nikita Hovratov voted on patch set 7 V +1 CR +1 11/26/21, 20:36
-
Oli Bartsch voted on patch set 7 V +2 CR +2 11/26/21, 20:48
-
Oli Bartsch merged patch set 8 11/26/21, 20:48