Review main Merged

72290[TASK] Improve page permission copyFromParent tests and docs

Stefan Bürk CR +2 V +2 Normal +86 −9 updated 11/26/21, 20:48

Commit message

A new feature has been added with #89917 to provide the
possibility that user/group informations and permissions
are used from parent page where the new page is created,
instead of eventually configured defaults through long
standing TSconfig options, or even fallback to current
signed in backend user/user group.

The patch extend the test cases to make more clear
how this new feature is intended to work and improves
the feature .rst file to show how it can be leveraged.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 2027

Show 2 earlier messages
  1. Stefan Bürk uploaded patch set 1 11/25/21, 17:24

  2. Stefan Bürk uploaded patch set 2 11/25/21, 17:25

  1. core-ci voted on patch set 1 V +1 11/25/21, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19749

  2. core-ci voted on patch set 2 V +1 11/25/21, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19750

  3. Christian Kuhn commented on patch set 2 11/26/21, 12:47

    This change is ready for review.
    makes sense. please finish.

    PagePermissionTest.php:159

    Use actionService->modifyRecord()
  4. Stefan Bürk voted on patch set 2 CR -1 11/26/21, 12:48

  5. Christian Kuhn voted on patch set 2 CR -1 11/26/21, 12:48

  6. Christian Kuhn commented on patch set 2 11/26/21, 12:51

    we should also improve the feature .rst a bit to show some scenarios why this can be useful. will update when stefan pushed his update.
  7. Stefan Bürk uploaded patch set 3 11/26/21, 13:11

  8. Stefan Bürk commented on patch set 3 CR -1 11/26/21, 13:12

    Christian will extend the .rst file.

    PagePermissionTest.php:159 Reply

    Done
  9. core-ci voted on patch set 3 V +1 11/26/21, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19790

  10. Christian Kuhn uploaded patch set 4 11/26/21, 18:31

  11. Christian Kuhn uploaded patch set 5 11/26/21, 18:32

  12. Christian Kuhn updated the commit message in patch set 6 11/26/21, 18:33

  13. Christian Kuhn voted on patch set 6 V +1 CR +1 11/26/21, 18:35

  14. core-ci voted on patch set 4 V +1 11/26/21, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19820

  15. core-ci voted on patch set 5 V +1 11/26/21, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19821

  16. core-ci voted on patch set 6 V +1 11/26/21, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19822

  17. Nikita Hovratov commented on patch set 6 11/26/21, 19:09

    Feature-89917-InheritPageAccess.rst:57

    This closing bracket is wrong.
  18. Nikita Hovratov commented on patch set 6 11/26/21, 19:23

    intended
  19. Stefan Bürk uploaded patch set 7 11/26/21, 19:59

  20. Stefan Bürk commented on patch set 7 11/26/21, 20:00

    Reply

    Done

    Feature-89917-InheritPageAccess.rst:57 Reply

    Done
  21. core-ci voted on patch set 7 V +1 11/26/21, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19830

  22. Christian Kuhn voted on patch set 7 V +1 CR +1 11/26/21, 20:35

  23. Nikita Hovratov voted on patch set 7 V +1 CR +1 11/26/21, 20:36

  24. Oli Bartsch voted on patch set 7 V +2 CR +2 11/26/21, 20:48

  25. Oli Bartsch merged patch set 8 11/26/21, 20:48