Review 11.5 Merged

72298[BUGFIX] Speed up linkvalidator functional tests

Christian Kuhn CR +2 V +2 Normal +39 −39 updated 11/26/21, 11:07

Commit message

The ext:linkvalidator functional tests work with a
fictional domain name to test if the code finds broken
external links.

This can be unfortunate since it triggers DNS lookups
that can be slow - such stuff should be avoided in
functional tests anyway.

Solution is to use localhost as test domain with an
invalid path instead. This is more expressive, too.

The result can be stunning: My DNS resolver for whatever
reason takes ages to (not) resolve that domain using
dockerized runTests.sh. I got a similar result from
another coredev. The linkvalidator tests run nearly
five minutes without the patch and are down to two
seconds with patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 17

Review log 34

  1. Christian Kuhn commented on patch set 1 11/26/21, 10:35

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/26/21, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19784

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 11/26/21, 11:07

  4. Christian Kuhn merged patch set 2 11/26/21, 11:07