Review 11.5 Merged

72309[BUGFIX] Don't fail language:update command when translation missing

Christian Kuhn CR +2 V +2 Normal +39 −28 updated 11/27/21, 22:21

Commit message

Currently language:update command fails when
a translation of a extension is missing.

This has been fixed by returning a successful
status code even though the file was not found
on the translation server. With the additional
option '--fail-on-warnings' the command fails
if the download of a language pack was not
successful.

Missing files are still reported in CLI stdout
and it still fails if the server is not reachable.
Also missing translations are now logged.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 4

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 11/27/21, 22:02

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/27/21, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19902

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 11/27/21, 22:21

  4. Christian Kuhn merged patch set 2 11/27/21, 22:21