Review main Merged

72313[TASK] Avoid asserting sys_language in functional tests

Christian Kuhn CR +2 V +2 Nightmare +0 −3904 updated 11/26/21, 12:03

Commit message

Table sys_language is legacy since language setup
is bound exclusively to site config in v11. We don't
need to import sys_language rows and assert their
state in functional tests anymore.

In preparation of the soon starting v12 deprecation
removals, the patch drops sys_language table row
imports and table state asserting in all functional
tests that use .csv file based fixtures.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 979

Show 959 more files

Review log 45

  1. Christian Kuhn uploaded patch set 1 11/26/21, 11:45

  2. core-ci voted on patch set 1 V +1 11/26/21, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19785

  3. Oli Bartsch commented on patch set 1 V +1 CR +1 11/26/21, 12:02

    Thanks!
  4. Andreas Kienast voted on patch set 1 V +2 CR +2 11/26/21, 12:03

  5. Andreas Kienast merged patch set 2 11/26/21, 12:03