Review main Merged

72315[TASK] Drop todo from ToolbarItemInterface

Chris Müller CR +2 V +2 Easy +0 −3 updated 11/26/21, 19:32

Commit message

The work on this interface was 7 years ago, time to
remove the todo.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 89

  1. Chris Müller uploaded patch set 1 11/26/21, 18:46

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 11/26/21, 18:49

  3. Guido Schmechel voted on patch set 1 CR +1 11/26/21, 18:52

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 11/26/21, 18:52

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 11/26/21, 18:55

  6. core-ci voted on patch set 1 V +1 11/26/21, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19824

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 11/26/21, 19:07

  8. Christian Kuhn merged patch set 2 11/26/21, 19:07

  9. Benni Mack commented on patch set 2 11/26/21, 19:32

    ToolbarItemInterface.php:21

    the API really has its drawbacks (see Workspaces ToolbarItem implementation), but a @TODO didn't help, internal would have been better back then :)