Review main Merged Breaking

72316[!!!][TASK] Clean up module icons

Chris Müller CR +2 V +2 Normal +61 −125 updated 11/26/21, 22:40

Commit message

With #95888 icon identifiers provided by TYPO3.Icons
are used for module icons, where they were not
already in place. The previously referenced icons
are now removed for TYPO3 v12.0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 27

Show 7 more files

Review log 913

  1. Chris Müller uploaded patch set 1 11/26/21, 19:29

  2. Oliver Klee updated the commit message in patch set 2 11/26/21, 19:37

  3. core-ci voted on patch set 1 V -1 11/26/21, 19:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19828

  4. core-ci voted on patch set 2 V -1 11/26/21, 19:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19829

  5. Chris Müller uploaded patch set 3 11/26/21, 20:10

  6. core-ci voted on patch set 3 V +1 11/26/21, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19831

  7. Benni Mack commented on patch set 3 11/26/21, 21:00

    Hey, should we document the icon-identifier in the RST so people can migrate easily?
  8. Nikita Hovratov uploaded patch set 4 11/26/21, 21:25

  9. Nikita Hovratov commented on patch set 4 11/26/21, 21:26

    Reply

    Done
  10. core-ci voted on patch set 4 V +1 11/26/21, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19839

  11. Nikita Hovratov voted on patch set 4 V +1 CR +1 11/26/21, 21:50

  12. Benni Mack voted on patch set 4 V +2 CR +2 11/26/21, 22:39

  13. Benni Mack merged patch set 5 11/26/21, 22:40