Review main Merged

72317[BUGFIX] Properly handle readOnly in BackendLayoutWizardElement

Oli Bartsch CR +2 V +2 Normal +106 −80 updated 11/30/21, 17:24

Commit message

While the "readOnly" option is not supported as
columns config for renderType "belayoutwizard",
it might be automatically set by FormEngine in
case the field is defined with "l10n_display",
set to "defaultAsReadonly".

This is now properly handled.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1016

  1. Oli Bartsch uploaded patch set 1 11/26/21, 20:36

  2. Oli Bartsch updated the commit message in patch set 2 11/26/21, 20:50

  3. core-ci voted on patch set 1 V -1 11/26/21, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19833

  4. Oli Bartsch uploaded patch set 3 11/26/21, 21:05

  5. core-ci voted on patch set 2 V -1 11/26/21, 21:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19837

  6. core-ci voted on patch set 3 V -1 11/26/21, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19838

  7. core-ci voted on patch set 3 V +1 11/26/21, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19838

  8. Benni Mack wrote 11/29/21, 10:20

    Change destination moved from master to main
  9. Oli Bartsch updated the commit message in patch set 4 11/29/21, 13:03

  10. core-ci voted on patch set 4 V +1 11/29/21, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19987

  11. Oli Bartsch rebased onto patch set 5 11/29/21, 21:06

  12. core-ci voted on patch set 5 V +1 11/29/21, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20164

  13. Christian Kuhn voted on patch set 5 V +1 CR +1 11/30/21, 16:17

  14. Jochen Roth voted on patch set 5 V +1 CR +1 11/30/21, 17:11

  15. Oli Bartsch voted on patch set 5 V +2 CR +2 11/30/21, 17:24

  16. Oli Bartsch merged patch set 6 11/30/21, 17:24