Review main Merged

72318[BUGFIX] Properly handle readOnly in InputSlugElement

Oli Bartsch CR +2 V +2 Easy +34 −0 updated 11/30/21, 16:59

Commit message

While the "readOnly" option is not supported
as columns config for type "slug", it might be
automatically set by FormEngine in case the
field is defined with "l10n_display", set to
"defaultAsReadonly".

This is now properly handled.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1016

  1. Oli Bartsch uploaded patch set 1 11/26/21, 20:42

  2. Oli Bartsch updated the commit message in patch set 2 11/26/21, 20:50

  3. core-ci voted on patch set 2 V -1 11/26/21, 21:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19836

  4. core-ci voted on patch set 1 V +1 11/26/21, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19834

  5. core-ci commented on patch set 2 11/26/21, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19836

  6. core-ci voted on patch set 2 V +1 11/26/21, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19836

  7. Benni Mack voted on patch set 2 V +1 CR +1 11/28/21, 20:51

  8. Benni Mack wrote 11/29/21, 10:22

    Change destination moved from master to main
  9. Oli Bartsch updated the commit message in patch set 3 11/29/21, 13:04

  10. core-ci voted on patch set 3 V +1 11/29/21, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19988

  11. Oli Bartsch rebased onto patch set 4 11/29/21, 21:06

  12. core-ci voted on patch set 4 V +1 11/29/21, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20163

  13. Benni Mack voted on patch set 4 V +1 CR +1 11/30/21, 13:12

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 11/30/21, 16:17

  15. Oli Bartsch voted on patch set 4 V +2 CR +2 11/30/21, 16:59

  16. Oli Bartsch merged patch set 5 11/30/21, 16:59