Review main Merged

72319[BUGFIX] Prepare changed json_response middleware

Stefan Bürk CR +2 V +2 Easy +4 −6 updated 11/27/21, 23:37

Commit message

The json_response functional test extension will soon
avoid returning json encoded responses. This will make
the functional frontend test suite fully transparent
regarding responses.
This patch prepares a couple of frontend functional
tests towards this change.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Stefan Bürk uploaded patch set 1 11/27/21, 00:13

  2. core-ci voted on patch set 1 V -1 11/27/21, 00:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19843

  3. core-ci voted on patch set 1 V +1 11/27/21, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19843

  4. Christian Kuhn uploaded patch set 2 11/27/21, 23:12

  5. Christian Kuhn commented on patch set 2 11/27/21, 23:13

    This change is ready for review.
  6. core-ci voted on patch set 2 V +1 11/27/21, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19908

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 11/27/21, 23:36

  8. Christian Kuhn commented on patch set 2 11/27/21, 23:37

    i'll bow rules here a bit and will merge that test change patch.
  9. Christian Kuhn voted on patch set 2 V +2 CR +2 11/27/21, 23:37

  10. Christian Kuhn merged patch set 3 11/27/21, 23:37