Review main Merged

72320[BUGFIX] Fix JavaScript error in configuration module

Torben Hansen CR +2 V +2 Easy +7 −5 updated 11/27/21, 23:25

Commit message

When performing a search in the configuration module,
a JavaScript error will occur, if a possible expanded
tree node is not part of the search result.

This patch adds checks for existence of the scrollElement
variable.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Torben Hansen uploaded patch set 1 11/27/21, 06:16

  2. core-ci voted on patch set 1 V +1 11/27/21, 06:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19847

  3. Benni Mack voted on patch set 1 CR +1 11/27/21, 12:21

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 11/27/21, 23:21

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 11/27/21, 23:24

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 11/27/21, 23:25

  7. Christian Kuhn merged patch set 2 11/27/21, 23:25