72323[BUGFIX] Use generated TSFE in PageLinkBuilder
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1418
-
Andreas Kienast uploaded patch set 1 11/27/21, 13:41
-
Andreas Kienast uploaded patch set 2 11/27/21, 13:50
-
core-ci voted on patch set 1 V +1 11/27/21, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19860
-
Andreas Kienast uploaded patch set 3 11/27/21, 13:55
-
core-ci voted on patch set 2 V +1 11/27/21, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19862
-
core-ci voted on patch set 3 V +1 11/27/21, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19864
-
Stefan Bürk voted on patch set 3 V +1 CR +1 11/27/21, 14:21
-
Christian Kuhn commented on patch set 3 CR -1 11/27/21, 22:21
-
Benni Mack wrote 11/29/21, 10:19
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 4 11/29/21, 14:06
-
core-ci voted on patch set 4 V +1 11/29/21, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20088
-
Stefan Bürk commented on patch set 4 CR -1 12/15/21, 03:47
-1 again because of what Christian wrote.PageLinkBuilder.php:387Reply-1 again because of what Christian wrote. -
Benni Mack commented on patch set 4 12/16/21, 16:20
PageLinkBuilder.php:387ReplyI'm in much favor of adapting this change. Why? Because it is consistent with the rest and testing is much easier. This will show issues we have with the PageLinkBuilder, and can fix them with tests in a much better fashion. -
Christian Kuhn commented on patch set 4 V +1 CR +1 12/21/21, 15:55
PageLinkBuilder.php:387Replyok, the patch is simple and works as such. i documented my scenario in https://forge.typo3.org/issues/96421 ... in general something is wrong with the redirect record target link generation. -
Stefan Bürk voted on patch set 4 V +1 CR +1 12/21/21, 15:56
-
Benni Mack voted on patch set 4 V +1 CR +1 12/21/21, 16:03
-
Andreas Kienast voted on patch set 4 V +2 CR +2 12/21/21, 16:11
-
Andreas Kienast merged patch set 5 12/21/21, 16:11
PageLinkBuilder.php:387