Review main Merged

72324[BUGFIX] Fix includeCSS.inline for files with EXT: syntax

Torben Hansen CR +2 V +2 Easy +4 −3 updated 11/27/21, 21:39

Commit message

The feature page.includeCSS.inline checks the existence
of the given file with `is_file()`. This does not work
for files included with the EXT: prefix, since the
path to the filename is not fully resolved any more
since https://review.typo3.org/c/Packages/TYPO3.CMS/+/71457

This patch processes the given file using the
`getStreamlinedFileName` function in order to resolve
the relative path to the file.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Torben Hansen uploaded patch set 1 11/27/21, 14:40

  2. core-ci voted on patch set 1 V +1 11/27/21, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19867

  3. Andreas Kienast voted on patch set 1 CR +1 11/27/21, 15:07

  4. Andreas Kienast voted on patch set 1 V +1 11/27/21, 15:20

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 11/27/21, 21:36

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 11/27/21, 21:37

  7. Christian Kuhn commented on patch set 1 11/27/21, 21:38

    coverage wouldn't be bad ... but well ... pagerenderer ...
  8. Christian Kuhn merged patch set 2 11/27/21, 21:39