Review main Merged

72326[TASK] Streamline DataHandler functional tests

Christian Kuhn CR +2 V +2 Nightmare +1168 −1754 updated 11/27/21, 18:14

Commit message

* Obsolete importScenarioDataSet() by using
  importCSVDataSet() directly with absolute paths.
  IDE's now resolve these paths so they can be
  clicked to open, which is *much* more convenient
  when working with the .csv files.
* Similar, obsolete assertAssertionDataSet() by using
  assertCSVDataSet() directly.
* Protected constants.
* Late static binding for workspace init in setUp()
  to simplify and streamline workspace test inheritance.
* A couple of minor streamlinings.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 84

Show 64 more files

Review log 913

  1. Christian Kuhn uploaded patch set 1 11/27/21, 15:40

  2. core-ci voted on patch set 1 V +1 11/27/21, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19872

  3. Christian Kuhn uploaded patch set 2 11/27/21, 16:53

  4. Christian Kuhn updated the commit message in patch set 3 11/27/21, 17:03

  5. core-ci voted on patch set 2 V +1 11/27/21, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19875

  6. core-ci voted on patch set 3 V +1 11/27/21, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19876

  7. Stefan Bürk commented on patch set 3 V +1 CR +1 11/27/21, 17:44

    CheckValueTestForCheckboxesTest.php:26

    Nice finding.
  8. Andreas Kienast uploaded patch set 4 11/27/21, 17:59

  9. Andreas Kienast commented on patch set 4 V +1 CR +1 11/27/21, 18:00

    Nice one!
  10. Stefan Bürk voted on patch set 4 V +1 CR +1 11/27/21, 18:01

  11. core-ci voted on patch set 4 V +1 11/27/21, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19882

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 11/27/21, 18:14

  13. Andreas Kienast merged patch set 5 11/27/21, 18:14