Review main Merged

72327[BUGFIX] Create auto-redirects with default language page uid

Stefan Bürk CR +2 V +2 Easy +11 −10 updated 11/28/21, 21:41

Commit message

Creating auto redirects, if page slug is changed, has been extended
to add the target with LinkHandler 't3://' uri schema with #89327,
adding language argument '_language' to enforce the language for the
redirect, missing that that did not worked, which was solved through
adding '_language' argument handling in #96043.

As languge arguments '_language' and 'L' are ignored, if the provided
page uid is already the uid of the localized page, the parameter was
meaning less. Further this breaks language fallback handling, if the
localized page record is deleted.

This patch uses now the default language page uid for creating target
of auto-redirects to mitigate the issue that redirect will break if
localized page is deleted but language fallback is configured.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 45

  1. Stefan Bürk uploaded patch set 1 11/27/21, 15:52

  2. core-ci voted on patch set 1 V +1 11/27/21, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19873

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 11/27/21, 20:26

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/28/21, 21:41

  5. Benni Mack merged patch set 2 11/28/21, 21:41