Review main Merged Breaking

72338[!!!][TASK] Remove TypoScript option page.includeCSS/includeCSSLibs.import

Benni Mack CR +2 V +2 Normal +29 −50 updated 11/28/21, 22:14

Commit message

The option to use the @import syntax in TypoScript
"page.includeCSS" and "page.includeCSSLibs"
(.import subproperty per CSS file) will not work anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Benni Mack uploaded patch set 1 11/28/21, 12:34

  2. core-ci voted on patch set 1 V +1 11/28/21, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19926

  3. Wouter Wolters commented on patch set 1 11/28/21, 12:58

    RequestHandler.php:491

    unset($cssFileConfig); dropped here. In the other method it is still there. Could we either remove both or leave both in place?
  4. Benni Mack commented on patch set 2 11/28/21, 19:31

    Published edit on patch set 1.
  5. Benni Mack commented on patch set 2 11/28/21, 19:31

    RequestHandler.php:491 Reply

    Done
  6. Wouter Wolters voted on patch set 2 V +1 CR +1 11/28/21, 19:31

  7. core-ci voted on patch set 2 V +1 11/28/21, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19940

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 11/28/21, 19:48

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 11/28/21, 22:14

  10. Christian Kuhn merged patch set 3 11/28/21, 22:14