Review main Merged

72340[TASK] Adapt UnitTests to changed property types in UnitTestCase

Wouter Wolters CR +2 V +2 Hard +130 −130 updated 11/30/21, 10:36

Commit message

Adapt to a patch in typo3/testing-framework.

composer req --dev typo3/testing-framework:dev-main

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 119

Show 99 more files

Review log 1523

  1. Wouter Wolters uploaded patch set 1 11/28/21, 12:44

  2. Wouter Wolters uploaded patch set 2 11/28/21, 12:50

  3. core-ci voted on patch set 2 V -1 11/28/21, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19929

  4. Wouter Wolters uploaded patch set 3 11/28/21, 13:00

  5. core-ci voted on patch set 3 V -1 11/28/21, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19932

  6. core-ci voted on patch set 1 V -1 11/28/21, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19928

  7. Wouter Wolters uploaded patch set 4 11/28/21, 13:08

  8. Wouter Wolters uploaded patch set 5 11/28/21, 13:17

  9. core-ci voted on patch set 4 V -1 11/28/21, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19933

  10. core-ci voted on patch set 5 V +1 11/28/21, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19934

  11. Christian Kuhn uploaded patch set 6 11/28/21, 14:02

  12. core-ci voted on patch set 6 V +1 11/28/21, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19936

  13. Christian Kuhn voted on patch set 6 V +1 CR +1 11/28/21, 15:05

  14. Christian Kuhn commented on patch set 6 CR -2 11/28/21, 16:22

    we'll have to sort out some details.
  15. Benni Mack wrote 11/29/21, 10:22

    Change destination moved from master to main
  16. Benni Mack updated the commit message in patch set 7 11/29/21, 14:11

  17. core-ci voted on patch set 7 V +1 11/29/21, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20122

  18. Christian Kuhn voted on patch set 7 CR 0 11/30/21, 10:22

  19. Christian Kuhn uploaded patch set 8 11/30/21, 10:24

  20. Anja Leichsenring voted on patch set 8 V +1 CR +1 11/30/21, 10:34

  21. core-ci voted on patch set 8 V +1 11/30/21, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20201

  22. Christian Kuhn voted on patch set 8 V +2 CR +2 11/30/21, 10:36

  23. Christian Kuhn merged patch set 9 11/30/21, 10:36