Review main Merged

72373[TASK] Deprecate inline JavaScript in backend update signals

Oliver Hader CR +2 V +2 Normal +144 −5 updated 12/13/21, 18:19

Commit message

Deprecates BackendUtility::getUpdateSignalCode as well as using
custom singal callbacks providing `JScode` containing inline JavaScript.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1214

  1. Oliver Hader uploaded patch set 1 11/29/21, 14:39

  2. Benni Mack rebased onto patch set 2 11/30/21, 11:03

  3. core-ci voted on patch set 2 V +1 11/30/21, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20206

  4. Benni Mack voted on patch set 2 CR +1 12/01/21, 14:09

  5. Wouter Wolters voted on patch set 2 CR +1 12/01/21, 14:18

  6. Benni Mack voted on patch set 2 V +1 12/13/21, 12:28

  7. Benjamin Franzke commented on patch set 2 V +2 CR -1 12/13/21, 13:16

    BackendUtility.php:2469

    be removed

    MethodCallStaticMatcher.php:112

    Rst file location isn't correct.
  8. Benjamin Franzke voted on patch set 2 V 0 12/13/21, 13:16

  9. Benni Mack commented on patch set 3 12/13/21, 14:13

    Published edit on patch set 2.
  10. Benjamin Franzke voted on patch set 3 CR +1 12/13/21, 14:15

  11. core-ci voted on patch set 3 V +1 12/13/21, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21035

  12. Benni Mack commented on patch set 3 V +1 CR +1 12/13/21, 14:55

    BackendUtility.php:2469 Reply

    Done

    MethodCallStaticMatcher.php:112 Reply

    Done
  13. Benjamin Franzke voted on patch set 3 V +2 CR +2 12/13/21, 18:19

  14. Benjamin Franzke merged patch set 4 12/13/21, 18:19