Review main Merged Breaking

72374[!!!][TASK] Remove GeneralUtility::uniqueList

Oli Bartsch CR +2 V +2 Easy +2 −24 updated 11/30/21, 11:39

Commit message

In #92607, GeneralUtility::uniqueList was migrated
to StringUtility::uniqueList and is therefore now
removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1218

  1. Oli Bartsch uploaded patch set 1 11/29/21, 14:43

  2. Oli Bartsch updated the commit message in patch set 2 11/29/21, 15:48

  3. core-ci voted on patch set 2 V +1 11/29/21, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20142

  4. core-ci voted on patch set 1 V +1 11/29/21, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20130

  5. Benni Mack voted on patch set 2 V +1 CR +1 11/29/21, 19:55

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 11/29/21, 22:43

  7. Oli Bartsch uploaded patch set 3 11/29/21, 23:19

  8. Benni Mack voted on patch set 3 V +1 CR +1 11/29/21, 23:21

  9. core-ci voted on patch set 3 V +1 11/29/21, 23:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20174

  10. Oli Bartsch uploaded patch set 4 11/30/21, 09:44

  11. Oli Bartsch uploaded patch set 5 11/30/21, 09:57

  12. core-ci voted on patch set 4 V +1 11/30/21, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20190

  13. core-ci voted on patch set 5 V +1 11/30/21, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20195

  14. Oli Bartsch uploaded patch set 6 11/30/21, 11:04

  15. core-ci voted on patch set 6 V +1 11/30/21, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20207

  16. Christian Kuhn voted on patch set 6 V +1 CR +1 11/30/21, 11:36

  17. Benni Mack voted on patch set 6 V +2 CR +2 11/30/21, 11:39

  18. Benni Mack merged patch set 7 11/30/21, 11:39