Review main Merged Breaking

72375[!!!][TASK] Remove GeneralUtility::stdAuthCode

Oli Bartsch CR +2 V +2 Easy +2 −35 updated 11/29/21, 23:10

Commit message

GeneralUtility::stdAuthCode is unused since at
least v9 and is therefore now removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 811

  1. Oli Bartsch uploaded patch set 1 11/29/21, 15:02

  2. Oli Bartsch updated the commit message in patch set 2 11/29/21, 15:12

  3. Oli Bartsch updated the commit message in patch set 3 11/29/21, 15:49

  4. core-ci voted on patch set 1 V +1 11/29/21, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20131

  5. core-ci voted on patch set 2 V -1 11/29/21, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20134

  6. core-ci voted on patch set 3 V +1 11/29/21, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20143

  7. Benni Mack voted on patch set 3 V +1 CR +1 11/29/21, 19:55

  8. Nikita Hovratov voted on patch set 3 V +1 CR +1 11/29/21, 22:01

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 11/29/21, 22:47

  10. Benni Mack voted on patch set 3 V +2 CR +2 11/29/21, 23:09

  11. Benni Mack merged patch set 4 11/29/21, 23:10