Review main Merged Breaking

72376[!!!][TASK] Remove deprecated BackendUtility::viewOnClick

Oliver Hader CR +2 V +2 Normal +2 −94 updated 11/30/21, 12:17

Commit message

Removes deprecated BackendUtility::viewOnClick, which should have
been replaced with \TYPO3\CMS\Backend\Routing\PreviewUriBuilder.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Oliver Hader uploaded patch set 1 11/29/21, 15:05

  2. core-ci voted on patch set 1 V +1 11/29/21, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20132

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/29/21, 23:21

  4. Oli Bartsch uploaded patch set 2 11/29/21, 23:23

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 11/29/21, 23:23

  6. core-ci voted on patch set 2 V +1 11/29/21, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20176

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/30/21, 09:01

  8. Benni Mack merged patch set 3 11/30/21, 09:01

  9. Oliver Hader commented on patch set 3 11/30/21, 12:17

    I just realized I forgot to add the `[!!!]` - thanks that you took care! +1