Review main Merged Breaking

72377[!!!][TASK] Remove GeneralUtility::rmFromList

Oli Bartsch CR +2 V +2 Normal +2 −67 updated 11/30/21, 10:27

Commit message

GeneralUtility::rmFromList is unused since at
least v10 and is therefore now removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1018

  1. Oli Bartsch uploaded patch set 1 11/29/21, 15:08

  2. Oli Bartsch updated the commit message in patch set 2 11/29/21, 15:12

  3. Oli Bartsch updated the commit message in patch set 3 11/29/21, 15:50

  4. core-ci voted on patch set 3 V -1 11/29/21, 18:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20144

  5. core-ci voted on patch set 1 V +1 11/29/21, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20133

  6. core-ci voted on patch set 2 V +1 11/29/21, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20135

  7. core-ci voted on patch set 3 V +1 11/29/21, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20144

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 11/29/21, 22:45

  9. Oli Bartsch uploaded patch set 4 11/29/21, 23:17

  10. core-ci voted on patch set 4 V +1 11/29/21, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20172

  11. Oli Bartsch uploaded patch set 5 11/30/21, 09:44

  12. Oli Bartsch uploaded patch set 6 11/30/21, 09:58

  13. core-ci voted on patch set 5 V +1 11/30/21, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20189

  14. Benni Mack voted on patch set 6 V +1 CR +1 11/30/21, 10:20

  15. core-ci voted on patch set 6 V -1 11/30/21, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20197

  16. core-ci voted on patch set 6 V +1 11/30/21, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20197

  17. Christian Kuhn voted on patch set 6 V +2 CR +2 11/30/21, 10:27

  18. Christian Kuhn merged patch set 7 11/30/21, 10:27