Review main Merged Breaking

72378[!!!][TASK] Remove HTTP headers manipulating methods in HttpUtility

Oli Bartsch CR +2 V +2 Normal +6 −47 updated 11/30/21, 10:20

Commit message

In order to properly handle PSR-7 response objects, methods, which
directly manipulate HTTP headers, should be avoided. Therefore
following methods from HttpUtility are now removed:

- `redirect()`
- `setResponseCode()`
- `setResponseCodeAndExit()`

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1015

  1. Oli Bartsch uploaded patch set 1 11/29/21, 15:16

  2. Oli Bartsch updated the commit message in patch set 2 11/29/21, 15:53

  3. core-ci voted on patch set 2 V +1 11/29/21, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20145

  4. core-ci voted on patch set 1 V +1 11/29/21, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20136

  5. Benni Mack voted on patch set 2 V +1 CR +1 11/29/21, 19:56

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 11/29/21, 22:44

  7. Oli Bartsch uploaded patch set 3 11/29/21, 23:18

  8. core-ci voted on patch set 3 V +1 11/29/21, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20173

  9. Oli Bartsch uploaded patch set 4 11/30/21, 09:45

  10. Oli Bartsch uploaded patch set 5 11/30/21, 09:56

  11. core-ci voted on patch set 4 V -1 11/30/21, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20191

  12. core-ci voted on patch set 5 V +1 11/30/21, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20194

  13. Christian Kuhn voted on patch set 5 V +1 CR +1 11/30/21, 10:16

  14. Benni Mack voted on patch set 5 V +2 CR +2 11/30/21, 10:20

  15. Benni Mack merged patch set 6 11/30/21, 10:20