Review main Merged Breaking

72380[!!!][TASK] Remove possibility to pass record uid to AbstractTreeView::getIcon()

Oli Bartsch CR +2 V +2 Easy +5 −12 updated 11/29/21, 23:10

Commit message

It's no longer possible to pass a records' uid to
AbstractTreeView::getIcon(), since the methods
first argument "$row" is now type hinted "array".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/29/21, 15:44

  2. core-ci voted on patch set 1 V +1 11/29/21, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20141

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/29/21, 20:48

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 11/29/21, 22:46

  5. Benni Mack voted on patch set 1 V +2 CR +2 11/29/21, 23:10

  6. Benni Mack merged patch set 2 11/29/21, 23:10