Review main Merged

72383[BUGFIX] UploadedResourceViewHelper does not extend UploadViewHelper

Oli Bartsch CR +2 V +2 Normal +69 −3 updated 11/30/21, 11:42

Commit message

With #95486, the UploadViewHelper got extended
for a new tag attribute "accept", which can be used
to limit the allowed file types for an upload field. The
EXT:form UploadedResourceViewHelper, which extends
the UploadViewHelper, registers the "accept" argument
and if given, implodes the value and adds it as attribute
to the tag. This however now led to an exception since
the "accept" attribute got already added by the parent
class.

This is fixed by no longer extending UploadViewHelper,
but implementing the required logic directly in the
UploadedResourceViewHelper.

This step would have been necessary in v12 anyways,
see #95298.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 11/29/21, 18:16

  2. core-ci voted on patch set 1 V +1 11/29/21, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20151

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/30/21, 11:36

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/30/21, 11:38

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 11/30/21, 11:39

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 11/30/21, 11:42

  7. Oli Bartsch merged patch set 2 11/30/21, 11:42