Review main Merged Breaking

72388[!!!][TASK] Remove service getters in ModuleTemplate

Oli Bartsch CR +2 V +2 Easy +4 −24 updated 11/30/21, 09:25

Commit message

The methods getIconFactory() and getPageRenderer()
from ModuleTemplate are now removed, since they
exposed internal state, while hiding dependencies.

Those services have to be injected in the
corresponding controllers directly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 710

  1. Oli Bartsch uploaded patch set 1 11/29/21, 21:47

  2. Oli Bartsch updated the commit message in patch set 2 11/29/21, 21:48

  3. core-ci voted on patch set 1 V +1 11/29/21, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20166

  4. core-ci voted on patch set 2 V +1 11/29/21, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20167

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 11/29/21, 22:47

  6. Oli Bartsch uploaded patch set 3 11/29/21, 23:17

  7. core-ci voted on patch set 3 V +1 11/29/21, 23:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20171

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 11/30/21, 09:04

  9. Benni Mack voted on patch set 3 V +2 CR +2 11/30/21, 09:24

  10. Benni Mack merged patch set 4 11/30/21, 09:25