Review main Merged Breaking

72402[!!!][TASK] Remove support for inline JavaScript in fieldChangeFunc

Oliver Hader CR +2 V +2 Hard +102 −194 updated 12/02/21, 23:22

Commit message

Custom `FormEngine` nodes using internal property `fieldChangeFunc`
must assign instances implementing `OnFieldChangeInterface` - using
scalar values (inline JavaScript as string) is not supported anymore.

`OnFieldChangeInterface` existed in TYPO3 v11 already, which allows
custom implementations to be compatible with TYPO3 v11 and TYPO3 v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1726

Show 1 earlier messages
  1. Oliver Hader uploaded patch set 1 11/30/21, 12:15

  1. Oliver Hader updated the commit message in patch set 2 11/30/21, 12:16

  2. core-ci voted on patch set 1 V -1 11/30/21, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20221

  3. core-ci voted on patch set 2 V -1 11/30/21, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20222

  4. Oliver Hader uploaded patch set 3 11/30/21, 12:24

  5. core-ci voted on patch set 3 V -1 11/30/21, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20224

  6. Oliver Hader rebased onto patch set 4 11/30/21, 14:26

  7. core-ci voted on patch set 4 V -1 11/30/21, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20237

  8. Oliver Hader uploaded patch set 5 11/30/21, 15:25

  9. core-ci voted on patch set 5 V -1 11/30/21, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20239

  10. Benni Mack rebased onto patch set 6 12/01/21, 14:13

  11. core-ci voted on patch set 6 V -1 12/01/21, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20323

  12. Oliver Hader rebased onto patch set 7 12/02/21, 06:59

  13. core-ci voted on patch set 7 V +1 12/02/21, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20376

  14. Oliver Hader wrote 12/02/21, 08:05

    Topic set to inline-javascript
  15. Oliver Hader marked it work in progress 12/02/21, 08:21

  16. Oliver Hader uploaded patch set 8 12/02/21, 08:24

  17. core-ci voted on patch set 8 V -1 12/02/21, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20377

  18. Oliver Hader uploaded patch set 9 12/02/21, 10:42

  19. Oliver Hader commented on patch set 9 12/02/21, 10:44

    This change is ready for review.
  20. core-ci voted on patch set 9 V +1 12/02/21, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20386

  21. Christian Kuhn voted on patch set 9 V +1 CR +1 12/02/21, 19:50

  22. Benni Mack voted on patch set 9 V +1 CR +1 12/02/21, 20:03

  23. Wouter Wolters voted on patch set 9 CR +1 12/02/21, 22:32

  24. Christian Kuhn voted on patch set 9 V +2 CR +2 12/02/21, 23:22

  25. Christian Kuhn merged patch set 10 12/02/21, 23:22