72402[!!!][TASK] Remove support for inline JavaScript in fieldChangeFunc
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 13
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTreeElement.ts+3 −6
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php+5 −20
- typo3/sysext/backend/Classes/Form/Behavior/OnFieldChangeInterface.php+0 −8
- typo3/sysext/backend/Classes/Form/Behavior/OnFieldChangeTrait.php+9 −48
- typo3/sysext/backend/Classes/Form/Behavior/ReloadOnFieldChange.php+0 −25
- typo3/sysext/backend/Classes/Form/Behavior/UpdateBitmaskOnFieldChange.php+0 −25
- typo3/sysext/backend/Classes/Form/Behavior/UpdateValueOnFieldChange.php+0 −16
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+0 −3
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+4 −20
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+7 −17
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineLinkBrowserAdapter.js+2 −5
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96158-RemoveSupportForInlineJavaScriptInFieldChangeFunc.rstnew+71 −0
Review log 1726
Show 1 earlier messages
-
Oliver Hader uploaded patch set 1 11/30/21, 12:15
-
Oliver Hader updated the commit message in patch set 2 11/30/21, 12:16
-
core-ci voted on patch set 1 V -1 11/30/21, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20221
-
core-ci voted on patch set 2 V -1 11/30/21, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20222
-
Oliver Hader uploaded patch set 3 11/30/21, 12:24
-
core-ci voted on patch set 3 V -1 11/30/21, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20224
-
Oliver Hader rebased onto patch set 4 11/30/21, 14:26
-
core-ci voted on patch set 4 V -1 11/30/21, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20237
-
Oliver Hader uploaded patch set 5 11/30/21, 15:25
-
core-ci voted on patch set 5 V -1 11/30/21, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20239
-
Benni Mack rebased onto patch set 6 12/01/21, 14:13
-
core-ci voted on patch set 6 V -1 12/01/21, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20323
-
Oliver Hader rebased onto patch set 7 12/02/21, 06:59
-
core-ci voted on patch set 7 V +1 12/02/21, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20376
-
Oliver Hader wrote 12/02/21, 08:05
Topic set to inline-javascript -
Oliver Hader marked it work in progress 12/02/21, 08:21
-
Oliver Hader uploaded patch set 8 12/02/21, 08:24
-
core-ci voted on patch set 8 V -1 12/02/21, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20377
-
Oliver Hader uploaded patch set 9 12/02/21, 10:42
-
Oliver Hader commented on patch set 9 12/02/21, 10:44
This change is ready for review. -
core-ci voted on patch set 9 V +1 12/02/21, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20386
-
Christian Kuhn voted on patch set 9 V +1 CR +1 12/02/21, 19:50
-
Benni Mack voted on patch set 9 V +1 CR +1 12/02/21, 20:03
-
Wouter Wolters voted on patch set 9 CR +1 12/02/21, 22:32
-
Christian Kuhn voted on patch set 9 V +2 CR +2 12/02/21, 23:22
-
Christian Kuhn merged patch set 10 12/02/21, 23:22