Review main Merged

72408[BUGFIX] Use correct versioned pid/t3ver_state in various functional tests

Benni Mack CR +2 V +2 Easy +22 −16 updated 12/01/21, 13:32

Commit message

This change adapts leftover XML fixtures to use real PIDs instead
of pid=-1.

By this, some drive-by fixes within Extbase:

* Extbase count() queries now respect workspaces
* Extbase's QueryParser now filters out workspace overlays in ANY case

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 811

  1. Benni Mack uploaded patch set 1 11/30/21, 19:41

  2. Christian Kuhn commented on patch set 1 11/30/21, 19:51

    ... we need to get rid of .xml import crap ...
  3. core-ci voted on patch set 1 V -1 11/30/21, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20261

  4. Benni Mack uploaded patch set 2 12/01/21, 09:55

  5. core-ci voted on patch set 2 V +1 12/01/21, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20296

  6. Benni Mack updated the commit message in patch set 3 12/01/21, 12:21

  7. core-ci voted on patch set 3 V +1 12/01/21, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20305

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 12/01/21, 12:42

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 12/01/21, 13:30

  10. Benni Mack voted on patch set 3 V +2 CR +2 12/01/21, 13:32

  11. Benni Mack merged patch set 4 12/01/21, 13:32