Review 11.5 Merged

72430[BUGFIX] Fix deprecated functionality in Doctrine DBAL 3.x API

Benni Mack CR +2 V +2 Hard +214 −143 updated 12/07/21, 12:20

Commit message

The past changes of migrating to Doctrine DBAL 3.x
had some flaws:

* Not all changes from Doctrine DBAL 3.x was applied
* core relies on various invalid interfaces and classes, so the
  return types were wrong (also Tests used the old Statement class)
* No explicit ->execute() and ->iterateAssociative() calls
  and fetchColumn() vs. fetchOne()
* added executeQuery() and executeStatement() to QueryBuilder
  decorator class

This change adapts most places to help in migrating to Doctrine DBAL
3.x for TYPO3 v12, but also avoids some unneeded deprecations for now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 43

Show 23 more files

Review log 46

  1. Benni Mack commented on patch set 1 12/07/21, 11:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 12/07/21, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20714

  3. Christian Kuhn uploaded patch set 2 12/07/21, 11:53

  4. core-ci voted on patch set 2 V +1 12/07/21, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20717

  5. Benni Mack voted on patch set 2 V +2 CR +2 12/07/21, 12:20

  6. Benni Mack merged patch set 3 12/07/21, 12:20