Review 11.5 Merged

72431[BUGFIX] Adjust acceptance tests to the current state

Christian Kuhn CR +2 V +2 Normal +44 −28 updated 12/08/21, 20:43

Commit message

Some acceptance tests did not run in CI due to the
splitter not taking tests without doc comments into
account.

Of course some tests are broken when this is fixed
in the splitter. Fix both.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 918

  1. Christian Kuhn commented on patch set 1 12/08/21, 16:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/08/21, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20792

  3. Christian Kuhn voted on patch set 1 CR -1 12/08/21, 16:35

  4. Christian Kuhn updated the commit message in patch set 2 12/08/21, 16:59

  5. Christian Kuhn updated the commit message in patch set 3 12/08/21, 17:00

  6. Jochen Roth uploaded patch set 4 12/08/21, 17:06

  7. core-ci voted on patch set 2 V +1 12/08/21, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20795

  8. core-ci voted on patch set 3 V +1 12/08/21, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20796

  9. core-ci voted on patch set 4 V -1 12/08/21, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20800

  10. Christian Kuhn uploaded patch set 5 12/08/21, 18:50

  11. core-ci voted on patch set 5 V +1 12/08/21, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20808

  12. core-ci voted on patch set 5 V -1 12/08/21, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20809

  13. Christian Kuhn uploaded patch set 6 12/08/21, 19:41

  14. core-ci voted on patch set 6 V -1 12/08/21, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20813

  15. core-ci voted on patch set 6 V +1 12/08/21, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20814

  16. core-ci commented on patch set 6 12/08/21, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20813

  17. Christian Kuhn voted on patch set 6 V +2 CR +2 12/08/21, 20:43

  18. Christian Kuhn merged patch set 7 12/08/21, 20:43