Review main Merged Breaking

72432[!!!][TASK] Remove RecordList hooks and interface

Oli Bartsch CR +2 V +2 Normal +5 −185 updated 11/30/21, 22:49

Commit message

The RecordList hooks, used to modify the actions,
icons and labels in the DatabaseRecordList are
superseded by modern PSR-14 events.

Therefore, the hooks and the interface are now removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. Oli Bartsch uploaded patch set 1 11/30/21, 21:56

  2. Wouter Wolters commented on patch set 1 11/30/21, 22:06

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:32

    should be placed after line 36 IMO
  3. core-ci voted on patch set 1 V -1 11/30/21, 22:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20273

  4. Oli Bartsch uploaded patch set 2 11/30/21, 22:17

  5. Oli Bartsch uploaded patch set 3 11/30/21, 22:24

  6. Oli Bartsch commented on patch set 3 11/30/21, 22:25

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:32 Reply

    Totally right.
  7. core-ci voted on patch set 2 V -1 11/30/21, 22:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20276

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 11/30/21, 22:36

  9. core-ci voted on patch set 3 V +1 11/30/21, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20277

  10. Benni Mack voted on patch set 3 V +2 CR +2 11/30/21, 22:49

  11. Benni Mack merged patch set 4 11/30/21, 22:49