72437[FEATURE] Introduce RedirectWasHitEvent
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96147-NewPSR-14RedirectWasHitEvent.rstnew+82 −0
- typo3/sysext/redirects/Classes/Event/RedirectWasHitEvent.php2new+77 −0
- typo3/sysext/redirects/Classes/EventListener/IncrementHitCount.php2new+57 −0
- typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php+27 −45
- typo3/sysext/redirects/Configuration/Services.yaml+5 −0
- typo3/sysext/redirects/Tests/Functional/EventListener/Fixtures/Redirects.xmlnew+23 −0
- typo3/sysext/redirects/Tests/Functional/EventListener/IncrementHitCountTest.phpnew+99 −0
Review log 2433
Show 58 earlier messages
-
Oli Bartsch uploaded patch set 1 12/01/21, 12:42
-
Oli Bartsch uploaded patch set 2 12/01/21, 12:45
-
Oli Bartsch updated the commit message in patch set 3 12/01/21, 12:48
-
core-ci voted on patch set 1 V +1 12/01/21, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20311
-
core-ci voted on patch set 2 V +1 12/01/21, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20312
-
core-ci voted on patch set 3 V +1 12/01/21, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20313
-
Christian Kuhn voted on patch set 3 V +1 CR +1 12/01/21, 13:07
-
Benni Mack commented on patch set 3 CR -1 12/01/21, 13:09
I recommend moving the HitCount functionality directly into an event listener, making the Event even more generic "RedirectWasHitEvent". If we allow to change the Response, this Event will become even more powerful (and more generic).
-
Stefan Bürk commented on patch set 3 12/01/21, 13:18
Could we also have some functional tests for the hit counting stuff anyway ? Could not find any on a quick look, and would be nice to have some coverage here. If not, would make some later (had it on my personal todo anyway). -
Oli Bartsch uploaded patch set 4 12/01/21, 16:58
-
core-ci voted on patch set 4 V +1 12/01/21, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20345
-
Oli Bartsch uploaded patch set 5 12/01/21, 18:10
-
Oli Bartsch uploaded patch set 6 12/01/21, 18:18
-
core-ci voted on patch set 5 V -1 12/01/21, 18:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20351
-
core-ci voted on patch set 6 V +1 12/01/21, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20352
-
Stefan Bürk commented on patch set 6 V +1 CR +1 12/01/21, 19:46
Reply
Thanks for adding the tests, and for the feature at all.Nice little feature. -
Oli Bartsch commented on patch set 6 V -1 12/01/21, 19:46
Will do some rework. -
Stefan Bürk wrote 12/01/21, 19:47
Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech> -
Stefan Bürk wrote 12/01/21, 19:47
Removed Verified+1 by Stefan Bürk <stefan@buerk.tech> -
Oli Bartsch uploaded patch set 7 12/01/21, 20:26
-
Oli Bartsch uploaded patch set 8 12/01/21, 20:30
-
core-ci voted on patch set 7 V -1 12/01/21, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20361
-
core-ci voted on patch set 8 V +1 12/01/21, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20363
-
Stefan Bürk voted on patch set 8 V +1 CR +1 12/01/21, 20:51
-
Benni Mack commented on patch set 8 12/01/21, 21:20
RedirectWasHitEvent.php:58do we need a setter?IncrementHitCount.php:28listeners can become final -
Oli Bartsch uploaded patch set 9 12/01/21, 21:32
-
Oli Bartsch commented on patch set 9 12/01/21, 21:33
RedirectWasHitEvent.php:58ReplyYes, see RST regarding the option to dynamically disable the hit counter.IncrementHitCount.php:28ReplyDone -
core-ci voted on patch set 9 V +1 12/01/21, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20369
-
Benni Mack voted on patch set 9 V +1 CR +1 12/01/21, 21:59
-
Stefan Bürk voted on patch set 9 V +1 CR +1 12/01/21, 22:00
-
Oli Bartsch voted on patch set 9 V +2 CR +2 12/01/21, 22:35
-
Oli Bartsch merged patch set 10 12/01/21, 22:35