Review main Merged

72444[BUGFIX] Stabilize formengine input tests

Jochen Roth CR +2 V +2 Easy +4 −36 updated 12/01/21, 19:59

Commit message

In some cases the tabs are not in viewport
so the elements can't be click by any
acceptance test.

This has been fixed by scrolling the tabs
into the viewport to make sure the ac test
is able to click the item.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 918

  1. Jochen Roth uploaded patch set 1 12/01/21, 15:25

  2. Jochen Roth uploaded patch set 2 12/01/21, 15:26

  3. core-ci voted on patch set 1 V +1 12/01/21, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20330

  4. core-ci voted on patch set 2 V +1 12/01/21, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20331

  5. core-ci commented on patch set 2 12/01/21, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20332

  6. core-ci commented on patch set 2 12/01/21, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20333

  7. core-ci commented on patch set 2 12/01/21, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20335

  8. core-ci commented on patch set 2 12/01/21, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20336

  9. core-ci commented on patch set 2 12/01/21, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20337

  10. Jochen Roth updated the commit message in patch set 3 12/01/21, 17:17

  11. Christian Kuhn rebased onto patch set 4 12/01/21, 17:19

  12. core-ci voted on patch set 3 V +1 12/01/21, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20346

  13. core-ci voted on patch set 4 V +1 12/01/21, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20347

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 12/01/21, 17:40

  15. Stefan Bürk voted on patch set 4 V +1 CR +1 12/01/21, 19:33

  16. Nikita Hovratov voted on patch set 4 V +1 CR +1 12/01/21, 19:59

  17. Christian Kuhn voted on patch set 4 V +2 CR +2 12/01/21, 19:59

  18. Christian Kuhn merged patch set 5 12/01/21, 19:59