Review main Merged Breaking

72445[!!!][TASK] Remove extbase ControllerContext

Christian Kuhn CR +2 V +2 Hard +49 −444 updated 01/06/22, 15:01

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 18

Review log 1218

  1. Christian Kuhn uploaded patch set 1 12/01/21, 19:30

  2. core-ci voted on patch set 1 V -1 12/01/21, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20353

  3. Christian Kuhn uploaded patch set 2 12/01/21, 19:33

  4. core-ci voted on patch set 2 V -1 12/01/21, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20355

  5. Christian Kuhn uploaded patch set 3 12/02/21, 12:30

  6. core-ci voted on patch set 3 V -1 12/02/21, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20392

  7. Christian Kuhn uploaded patch set 4 12/02/21, 12:43

  8. core-ci voted on patch set 4 V +1 12/02/21, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20395

  9. Christian Kuhn uploaded patch set 5 12/02/21, 13:11

  10. core-ci voted on patch set 5 V +1 12/02/21, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20401

  11. Christian Kuhn uploaded patch set 6 12/02/21, 13:26

  12. Benni Mack voted on patch set 6 V +1 CR +1 12/02/21, 13:29

  13. core-ci voted on patch set 6 V +1 12/02/21, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20402

  14. Stefan Bürk voted on patch set 6 V +1 CR +1 12/02/21, 14:03

  15. Christian Kuhn voted on patch set 6 V +2 CR +2 12/02/21, 14:07

  16. Christian Kuhn merged patch set 7 12/02/21, 14:08

  17. Markus Klein commented on patch set 7 12/20/21, 22:57

    ActionController.php:616

    This obviously introduced a change of behaviour. These lines were run previously as part of ->setcontrollerContext, which was called AFTER the ->setViewConfiguration call. So the order of how Fluid paths are initialized are now swapped. I did not fully grasp how this actually worked out in v11 at all (always replacing the configured values with the default ones... anyone?), but as my patch shows, there is for sure a major difference: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72703
  18. Christian Kuhn commented on patch set 7 01/06/22, 15:01

    ActionController.php:616 Reply

    Done