Review main Merged

72446[TASK] Integrate sqlite acceptance testing

Stefan Bürk CR +2 V +2 Normal +127 −15 updated 12/15/21, 16:46

Commit message

Add support for sqlite acceptance testing to
'Build/Scripts/runTests.sh'.

Run acceptance/sqlite testing with PHP 8.1 in nightly
as a first execution implementation, which could be
reshuffled when minimum PHP requirements have
been decided.

Furthermore two acceptance tests are marked as skipped
when executed with sqlite, which should be fixed in
dedicated patches:

* MaintenanceCest.php->analyzeDatabaseStructureWorks()
  Skipped, as database compare is never clean and ends
  in endless loop with sqlite, when ext:indexed_search is
  installed. This is a general issue, existing at least
  since v10.4. Needs investigation and a dedicated patch.

* UpgradeCest.php->seeUpgradeWizard()
  Skipped, as utf-8 charset upgrade wizard is not visible
  for sqlite dbms backend, thus rendering this test obsolete
  with sqlite. Needs another update wizard test and possibly
  a dedicated patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2136

Show 611 earlier messages
  1. Stefan Bürk uploaded patch set 1 12/02/21, 01:10

  2. Stefan Bürk marked it work in progress 12/02/21, 01:11

  3. core-ci voted on patch set 1 V -1 12/02/21, 01:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20373

  4. Stefan Bürk uploaded patch set 2 12/05/21, 16:43

  5. core-ci voted on patch set 2 V -1 12/05/21, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20605

  6. Stefan Bürk uploaded patch set 3 12/05/21, 21:34

  7. core-ci voted on patch set 3 V -1 12/05/21, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20617

  8. core-ci commented on patch set 3 12/06/21, 01:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20617

  9. Stefan Bürk uploaded patch set 4 12/09/21, 00:40

  10. core-ci voted on patch set 4 V -1 12/09/21, 00:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20833

  11. Stefan Bürk rebased onto patch set 5 12/11/21, 20:20

  1. core-ci voted on patch set 5 V -1 12/11/21, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20990

  2. Stefan Bürk updated the commit message in patch set 6 12/11/21, 23:20

  3. core-ci voted on patch set 6 V -1 12/11/21, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20991

  4. Stefan Bürk uploaded patch set 7 12/11/21, 23:49

  5. core-ci voted on patch set 7 V -1 12/11/21, 23:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20992

  6. Stefan Bürk uploaded patch set 8 12/11/21, 23:53

  7. core-ci voted on patch set 8 V -1 12/12/21, 00:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20993

  8. Stefan Bürk uploaded patch set 9 12/12/21, 00:13

  9. Stefan Bürk updated the commit message in patch set 10 12/12/21, 00:17

  10. core-ci voted on patch set 10 V +1 12/12/21, 00:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20995

  11. core-ci voted on patch set 9 V +1 12/12/21, 00:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20994

  12. Stefan Bürk commented on patch set 10 12/12/21, 00:32

  13. core-ci commented on patch set 10 12/12/21, 01:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20996

  14. Stefan Bürk updated the commit message in patch set 11 12/12/21, 01:14

  15. Stefan Bürk commented on patch set 11 12/12/21, 01:14

    Nightly was happy, last patchset (11) was just commit message edit.
  16. Stefan Bürk updated the commit message in patch set 12 12/12/21, 01:15

  17. core-ci voted on patch set 11 V +1 12/12/21, 01:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20998

  18. core-ci voted on patch set 12 V +1 12/12/21, 01:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20999

  19. Christian Kuhn commented on patch set 12 12/13/21, 18:43

    will review tomorrow.
  20. Christian Kuhn updated the commit message in patch set 13 12/15/21, 14:00

  21. Christian Kuhn voted on patch set 13 V +1 CR +1 12/15/21, 14:02

  22. core-ci voted on patch set 13 V +1 12/15/21, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21127

  23. Benni Mack voted on patch set 13 V +1 CR +1 12/15/21, 15:35

  24. Christian Kuhn voted on patch set 13 V +2 CR +2 12/15/21, 16:46

  25. Christian Kuhn merged patch set 14 12/15/21, 16:46