Review main Merged

72453[BUGFIX] Move extension scanner entry of arrayDiffAssocRecursive

Oli Bartsch CR +2 V +2 Easy +6 −7 updated 12/02/21, 12:50

Commit message

With #94137, the ArrayUtility::arrayDiffAssocRecursive
method was adjusted to actually behave like `array_diff_assoc`.

To not introduce a breaking change after 11.0, a third
parameter was added to enable the correct behaviour.
This parameter however will be removed again in v12.

Therefore, the extension scanner entry hast to be
placed in MethodArgumentDroppedStaticMatcher
instead of MethodCallStaticMatcher, because only
the last parameter is deprecated, not the whole
method.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 12/02/21, 12:31

  2. Oli Bartsch updated the commit message in patch set 2 12/02/21, 12:32

  3. Andreas Kienast voted on patch set 2 V +1 CR +1 12/02/21, 12:33

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 12/02/21, 12:41

  5. core-ci voted on patch set 1 V +1 12/02/21, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20393

  6. core-ci voted on patch set 2 V +1 12/02/21, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20394

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 12/02/21, 12:50

  8. Oli Bartsch merged patch set 3 12/02/21, 12:50