Review main Merged Breaking

72454[!!!][TASK] Remove third parameter from ArrayUtility::arrayDiffAssocRecursive()

Oli Bartsch CR +2 V +2 Easy +14 −22 updated 12/02/21, 13:43

Commit message

With #94137, the ArrayUtility::arrayDiffAssocRecursive
method was adjusted to actually behave like `array_diff_assoc`.

To not introduce a breaking change after 11.0, a third
parameter was added to enable the correct behaviour.

This parameter is now removed, the method does
now always behave correct.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 56

  1. Oli Bartsch uploaded patch set 1 12/02/21, 13:05

  2. core-ci voted on patch set 1 V +1 12/02/21, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20398

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/02/21, 13:29

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 12/02/21, 13:29

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 12/02/21, 13:43

  6. Oli Bartsch merged patch set 2 12/02/21, 13:43