Review main Merged

72458[TASK] Remove an internal helper method in RenderingContext

Christian Kuhn CR +2 V +2 Easy +0 −10 updated 12/02/21, 15:22

Commit message

@internal injectViewHelperVariableContainer() was used by
testing-framework ViewHelperBaseTestcase, which has been
deprecated for v11 compatible testing-framework and removed
in testing-framework "v12" main branch. It can be removed now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/02/21, 14:25

  2. core-ci voted on patch set 1 V +1 12/02/21, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20408

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 12/02/21, 15:17

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 12/02/21, 15:20

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/02/21, 15:22

  6. Christian Kuhn merged patch set 2 12/02/21, 15:22