Review main Merged

72463[BUGFIX] Load all backend routes in installer controller

Simon Gilli CR +2 V +2 Easy +3 −2 updated 12/15/21, 07:37

Commit message

The routes added via ExtensionManagementUtility::addModule() are missing
when the UriBuilder/Router is used prior to ext_localconf loading.

Also for this particular case, multiple instances of the Router class
were created, as UriBuilder is loaded from the failsafe installtool
container instead of using an instance from the symfony container
(as created by LateBootService n loadExtLocalconfDatabaseAndExtTables).
This resulted in multiple routers being loaded with different sets of
routes.

This patch ensures that the routes are loaded from a UriBuilder/Router
instance that is fully populated with information from ext_localconf.
Therefore GeneralUtility::makeInstance() is avoided and
UriBuilder is fetched from the late booted container instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Simon Gilli uploaded patch set 1 12/02/21, 15:47

  2. core-ci voted on patch set 1 V +1 12/02/21, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20418

  3. Simon Gilli updated the commit message in patch set 2 12/02/21, 16:18

  4. Simon Gilli commented on patch set 2 12/02/21, 16:19

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 12/02/21, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20422

  6. Benjamin Franzke updated the commit message in patch set 3 12/02/21, 21:51

  7. core-ci voted on patch set 3 V +1 12/02/21, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20446

  8. Christian Kuhn commented on patch set 3 CR +1 12/02/21, 23:26

    makes sense logically, but did not test (yet). could test later if nobody else is quicker ...
  9. Markus Klein commented on patch set 3 12/03/21, 07:58

    InstallerController.php:1017

    maybe put a comment here, why we can't use GU:makeInstance here
  10. Benni Mack commented on patch set 4 12/09/21, 14:00

    Published edit on patch set 3.
  11. Oli Bartsch commented on patch set 4 12/09/21, 14:04

    InstallerController.php:1017 Reply

    Done
  12. core-ci voted on patch set 4 V +1 12/09/21, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20865

  13. Benjamin Franzke voted on patch set 4 V +1 CR +1 12/10/21, 08:18

  14. Stefan Bürk voted on patch set 4 CR +1 12/10/21, 09:04

  15. Benni Mack voted on patch set 4 V +2 CR +2 12/15/21, 07:37

  16. Benni Mack merged patch set 5 12/15/21, 07:37