Review main Merged

72468[BUGFIX] Do not add error in TypoScriptParser if modifier returns null

Jochen Roth CR +2 V +2 Easy +16 −0 updated 12/02/21, 23:28

Commit message

Currently, the TypoScriptParser adds an error when
the result of a modifier is null. This is, because
the line is not set to a new value in such a case
and the following switch statement is not expecting
a line with a value modifier.

This has been fixed by skipping further checks on
the value, if the modifier returns null.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Jochen Roth uploaded patch set 1 12/02/21, 17:17

  2. core-ci voted on patch set 1 V +1 12/02/21, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20428

  3. Nikita Hovratov uploaded patch set 2 12/02/21, 21:27

  4. Nikita Hovratov voted on patch set 2 V +1 CR +1 12/02/21, 21:28

  5. core-ci voted on patch set 2 V +1 12/02/21, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20445

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 12/02/21, 23:28

  7. Christian Kuhn merged patch set 3 12/02/21, 23:28