Review main Merged

72471[BUGFIX] Temporarily disable group access check

Oli Bartsch CR +2 V +2 Easy +7 −0 updated 12/03/21, 12:01

Commit message

To support editors, the page module checks
whether configured shortcut targets exist
and if they are accessible in the frontend
(e.g. not hidden). Otherwise, a info box is
displayed on the page, defining the shortcut.

However, in case a target page has group
restrictions defined (`pages.fe_group`), it
was previously declared as non accessible,
since no frontend group context exists in
backend.

This is now fixed by disabling the group
access, while searching for target pages.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Achim Fritz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Achim Fritz +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 12/02/21, 20:33

  2. core-ci voted on patch set 1 V +1 12/02/21, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20442

  3. Achim Fritz voted on patch set 1 V +1 CR +1 12/03/21, 07:36

  4. Benni Mack voted on patch set 1 V +1 CR +1 12/03/21, 07:54

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 12/03/21, 12:01

  6. Oli Bartsch merged patch set 2 12/03/21, 12:01