Review main Merged Breaking

72472[!!!][TASK] Remove last arguments of wrapClickMenuOnIcon()

Oli Bartsch CR +2 V +2 Easy +8 −28 updated 12/02/21, 23:30

Commit message

Since unrelated functionality was moved to a
dedicated method, the corresponding arguments
are now removed. Therefore, the method does
now always return `string`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 56

  1. Oli Bartsch uploaded patch set 1 12/02/21, 20:50

  2. core-ci voted on patch set 1 V +1 12/02/21, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20443

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 12/02/21, 22:30

  4. Benni Mack voted on patch set 1 V +1 CR +1 12/02/21, 22:32

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/02/21, 23:30

  6. Christian Kuhn merged patch set 2 12/02/21, 23:30