Review main Merged Breaking

72475[!!!][TASK] Remove deprecated code from RelationHandler

Christian Kuhn CR +2 V +2 Normal +33 −138 updated 12/03/21, 13:50

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1115

  1. Christian Kuhn uploaded patch set 1 12/03/21, 00:14

  2. Christian Kuhn uploaded patch set 2 12/03/21, 00:17

  3. Christian Kuhn uploaded patch set 3 12/03/21, 00:19

  4. core-ci voted on patch set 1 V -1 12/03/21, 00:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20451

  5. core-ci voted on patch set 2 V -1 12/03/21, 00:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20452

  6. core-ci voted on patch set 3 V -1 12/03/21, 00:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20453

  7. Oliver Klee commented on patch set 3 12/03/21, 11:56

    RelationHandler.php:1211

    We need to update this line as well to match the changed functionality.
  8. Christian Kuhn commented on patch set 3 12/03/21, 12:39

    RelationHandler.php:1211 Reply

    Ack
  9. Christian Kuhn uploaded patch set 4 12/03/21, 12:43

  10. Oliver Klee wrote 12/03/21, 12:45

    Removed cc Oliver Klee.
  11. Andreas Kienast voted on patch set 4 V +1 CR +1 12/03/21, 12:52

  12. core-ci voted on patch set 4 V +1 12/03/21, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20485

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 12/03/21, 13:21

  14. Benni Mack voted on patch set 4 V +2 CR +2 12/03/21, 13:50

  15. Benni Mack merged patch set 5 12/03/21, 13:50