Review main Merged

72477[BUGFIX] Check extension version number format

Oli Bartsch CR +2 V +2 Normal +97 −0 updated 12/03/21, 13:33

Commit message

A false check in the TER API allowed to use
arbitrary version strings, as soon as they start
with the known `XXX.XXX.XXX` schema. This
will be fixed in TER API. However, core as receiver
should also validate the incoming data, before
storing them in the database.

Therefore, the same version number check,
which is used in the TER API, is now also
applied in the ExtensionXmlParser.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Oli Bartsch uploaded patch set 1 12/03/21, 11:02

  2. core-ci voted on patch set 1 V +1 12/03/21, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20466

  3. Christian Kuhn commented on patch set 1 12/03/21, 11:17

    ExtensionXmlParser.php:482

    smells as if a unit test would be great.
  4. Oli Bartsch uploaded patch set 2 12/03/21, 12:00

  5. Oli Bartsch commented on patch set 2 12/03/21, 12:00

    ExtensionXmlParser.php:482 Reply

    Done
  6. core-ci voted on patch set 2 V -1 12/03/21, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20473

  7. Oli Bartsch uploaded patch set 3 12/03/21, 12:17

  8. core-ci voted on patch set 3 V +1 12/03/21, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20483

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 12/03/21, 12:36

  10. Oliver Hader voted on patch set 3 V +1 CR +1 12/03/21, 13:21

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 12/03/21, 13:33

  12. Oli Bartsch merged patch set 4 12/03/21, 13:33