Review main Merged

72479[TASK] Use get_debug_type() where applicable

Andreas Kienast CR +2 V +2 Easy +15 −17 updated 12/04/21, 14:37

Commit message

In some exception messages, the exact object type is rendered.
Previously, this is done via `is_object()`, `get_class()` and
`gettype()`. With PHP 8 (and the symfony/polyfill-php80 package),
`get_debug_type()` may be used, providing the same functionality.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1015

  1. Andreas Kienast uploaded patch set 1 12/03/21, 12:09

  2. Andreas Kienast uploaded patch set 2 12/03/21, 12:11

  3. Andreas Kienast updated the commit message in patch set 3 12/03/21, 12:12

  4. core-ci voted on patch set 3 V -1 12/03/21, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20480

  5. core-ci voted on patch set 1 V -1 12/03/21, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20476

  6. core-ci voted on patch set 2 V -1 12/03/21, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20478

  7. Andreas Kienast uploaded patch set 4 12/03/21, 12:35

  8. core-ci voted on patch set 4 V +1 12/03/21, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20484

  9. Andreas Kienast updated the commit message in patch set 5 12/03/21, 12:54

  10. core-ci voted on patch set 5 V +1 12/03/21, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20488

  11. Oliver Hader voted on patch set 5 CR +1 12/03/21, 15:12

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 12/04/21, 14:33

  13. Stefan Bürk voted on patch set 5 V +1 CR +1 12/04/21, 14:34

  14. Andreas Kienast voted on patch set 5 V +2 CR +2 12/04/21, 14:37

  15. Andreas Kienast merged patch set 6 12/04/21, 14:37